netdev - Re: [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130904185145.GC13136@order.stressinduktion.org>
Date:	Wed, 4 Sep 2013 20:51:45 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	michele@...syn.org, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org, sasha.levin@...cle.com
Subject: Re: [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add

On Wed, Sep 04, 2013 at 02:13:01PM -0400, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Tue, 3 Sep 2013 02:13:31 +0200
> 
> > Hi!
> > 
> > On Mon, Sep 02, 2013 at 10:31:28PM +0100, Michele Baldessari wrote:
> >> with the latest linux master git tree from Linus
> >> (248d296d6d9df384996c2ed95676b367d876d48c - 2 Sep) I can reproduceably oops 
> >> the kernel with the following commands:
> >> ip addrlabel flush
> >> ip addrlabel add prefix ::1/128              label 0
> >> ip addrlabel add prefix ::/0                 label 1
> > 
> > Thanks for the report! This patch should fix this issue:
> > 
> > [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add
> > 
> > Commit b67bfe0d42cac56c512dd5da4b1b347a23f4b70a ("hlist: drop
> > the node parameter from iterators") changed the behavior of
> > hlist_for_each_entry_safe to leave the p argument NULL.
> > 
> > Fix this up by tracking the last argument.
> > 
> > Reported-by: Michele Baldessari <michele@...syn.org>
> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > Cc: Sasha Levin <sasha.levin@...cle.com>
> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> 
> Applied.

Sorry I forgot to mention that this patch is also applicable to solve
this issue in the longterm 3.10 kernel. Maybe this should go to stable?

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html