netdev - Re: [PATCH] r8169: add ethtool eeprom change/dump feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9994507.zDXvCracdk@al>
Date:	Wed, 04 Sep 2013 11:55:59 +0200
From:	Peter Wu <lekensteyn@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com,
	hayeswang@...ltek.com, bhutchings@...arflare.com
Subject: Re: [PATCH] r8169: add ethtool eeprom change/dump feature

On Tuesday 03 September 2013 21:59:35 David Miller wrote:
> From: Peter Wu <lekensteyn@...il.com>
> Date: Thu, 29 Aug 2013 16:44:51 +0200
> 
> > This adds the ability to read and change EEPROM for 93C46/93C56 serial
> > EEPROM. Two-Wire serial interface and SPI are not supported. (Do not
> > even try this for SPI or other chips, it may break your hardware.)
> 
> Please block the operation on configurations, such as the aforementioned
> SPI, where it won't work.

I do not know how to detect those, as far as I know it's harmless, the r8168 
vendor driver does not perform other checks either. If I look at "Realtek 
RTL8411 EEPROM/eFUSE Datasheet 1.1", then SPI access is done via CONFIG0 which 
is then at offset 51h and not 50h (which is used for 9346CR).

This SPI seems to be used for the Boot ROM, not EEPROM. Even the "RTL8111E-VL-
CG" (May 2012) mentions the 9346CR register, so I think it is safe to assume 
that nothing breaks. At worst you read invalid values (ff) and writes are no-
op.

I can remove this scary warning from the commit message, but it would really 
be nice if a Realtek engineer could give more information on this.

Regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html