netdev - Re: question about __udp6_lib_err usage of __udp6_lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130904.232120.2047234060467188366.davem@davemloft.net>
Date:	Wed, 04 Sep 2013 23:21:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	davej@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: question about __udp6_lib_err usage of __udp6_lib_lookup

From: Dave Jones <davej@...hat.com>
Date: Wed, 4 Sep 2013 22:44:34 -0400

> __udp6_lib_lookup's prototype is ...
> 
> struct sock *__udp6_lib_lookup(struct net *net,
>                                       const struct in6_addr *saddr, __be16 sport,
>                                       const struct in6_addr *daddr, __be16 dport,
>                                       int dif, struct udp_table *udptable)
> 
> But the usage in __udp6_lib_err is...
> 
>  521         sk = __udp6_lib_lookup(dev_net(skb->dev), daddr, uh->dest,
>  522                                saddr, uh->source, inet6_iif(skb), udptable);
> 
> With the source/dest addr/port arguments swapped. Is this intentional ?

Yes, because we are looking at the headers of a packet we transmitted,
quoted in an ICMP response.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html