netdev - Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <62E39EC3-A2D5-4631-A21F-4F29D18A74D9@dominion.thruhere.net>
Date:	Thu, 5 Sep 2013 22:11:22 +0200
From:	Koen Kooi <koen@...inion.thruhere.net>
To:	Mark Jackson <mpfj-list@...flow.co.uk>
Cc:	Mugunthan V N <mugunthanvnm@...com>,
	Peter Korsgaard <jacmet@...site.dk>,
	linux-omap@...r.kernel.org, netdev@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, hvaibhav@...com,
	richardcochran@...il.com, tony@...mide.com,
	michal.bachraty@...il.com, michal.bachraty@...eamunlimited.com
Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt


Op 8 jul. 2013, om 14:42 heeft Mark Jackson <mpfj-list@...flow.co.uk> het volgende geschreven:

> On 18/01/13 05:14, Mugunthan V N wrote:
>> On 1/18/2013 3:48 AM, Peter Korsgaard wrote:
>>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old
>>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot
>>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the
>>> CPSW slaves, causing the driver to use a random hwaddr, which is some times
>>> troublesome.
>>> 
>>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes
>>> more sense to default to these rather than random ones. Add a fixup step
>>> which adds mac-address dt properties using the efuse addresses if the DTB
>>> didn't contain valid ones.
>>> 
>>> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
>>> 
>> 
>> This implementation looks fine.
>> Acked-by: Mugunthan V N <mugunthanvnm@...com>
> 
> Tested-by: Mark Jackson <mpfj-list@...flow.co.uk>

Tested-by: Koen Kooi <koen@...inion.thruhere.net>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html