netdev - Re: [net-next v4 1/7] i40e: main driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130905092633.253896e3@nehalam.linuxnetplumber.net>
Date:	Thu, 5 Sep 2013 09:26:33 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Jesse Brandeburg <jesse.brandeburg@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	Shannon Nelson <shannon.nelson@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [net-next v4 1/7] i40e: main driver core

More review comments, these are non-blocking, and can be fixed later.

Minor
-----
* style
    not a fan of doing own error codes and handling (ie. I40E_SUCCESS)
    which probably is side effect of OS abstraction.

* extra parens aren't needed on return
     return (budget > 0);

* i40e_config_netdev
    etherdev_size = (sizeof(struct i40e_netdev_priv));
	 Extra paren, only used once, unsigned vs signed, just
	 use sizeof()
    strlcpy(netdev->name, "eth%d", IFNAMSIZ-1);
        That is already done by alloc_etherdev
    memcpy(netdev->dev_addr, mac_addr, netdev->addr_len);
       netdev->addr_len is ETH_ALEN, mac_addr is ETH_ALEN
       just use constant size copy.
* i40e_init_module
    ret = pci_register_driver(&i40e_driver);
    return ret;
       assignment is unneeded, just do return pci_register_driver

* service timer
     since it is 1 HZ, you should use round_jiffies to align
     on clock boundary to save power.

* Why is Kbuild file used instead of Makefile like other drivers?

* Ethtool
  Need to use ethtool_cmd_speed_set othewise only lower bit set.

* Extension I40E_DEBUG_USER is non-standard

* What is is point of using snprintf() in i40e_get_drvinfo
	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
		 "%s", i40e_fw_version_str(&pf->hw));
  Already using strlcpy() for other fields.

* Ethtool ops can be const

* isn't vsi->netdev = NULL needed here.
s32 i40e_vsi_release(struct i40e_vsi *vsi)
	if (vsi->netdev_registered) {
			vsi->netdev_registered = false;
			if (vsi->netdev) {
				/* results in a call to i40e_close() */
				unregister_netdev(vsi->netdev);
				free_netdev(vsi->netdev);
			>>>>	vsi->netdev = NULL;


Enhancement
-----------
* Support Byte Queue Limits
  - might be tougher with VBE


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html