netdev - Re: [PATCH net-next v2] qlcnic: use standard NAPI weights

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130905.124606.910539581016843593.davem@davemloft.net>
Date:	Thu, 05 Sep 2013 12:46:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mschmidt@...hat.com
Cc:	himanshu.madhani@...gic.com, netdev@...r.kernel.org,
	edumazet@...gle.com, rajesh.borundia@...gic.com,
	shahed.shaikh@...gic.com, jitendra.kalsaria@...gic.com,
	sony.chacko@...gic.com, sucheta.chakraborty@...gic.com,
	Linux-Driver@...gic.com
Subject: Re: [PATCH net-next v2] qlcnic: use standard NAPI weights

From: Michal Schmidt <mschmidt@...hat.com>
Date: Wed, 04 Sep 2013 15:03:05 +0200

> Since commit 82dc3c63 ("net: introduce NAPI_POLL_WEIGHT")
> netif_napi_add() produces an error message if a NAPI poll weight
> greater than 64 is requested.
> 
> qlcnic requests the weight as large as 256 for some of its rings, and
> smaller values for other rings. For instance in qlcnic_82xx_napi_add()
> I think the intention was to give the tx+rx ring a bigger weight than
> to rx-only rings, but it's actually doing the opposite. So I'm assuming
> the weights do not really matter much.
> 
> Just use the standard NAPI weights for all rings.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> Acked-by: Himanshu Madhani <himanshu.madhani@...gic.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html