netdev - Re: [net-next v4] vxlan: Notify drivers for listening UDP port changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.03.1309061708540.21291@intel.com>
Date:	Fri, 6 Sep 2013 17:09:33 -0700 (PDT)
From:	Joseph Gasparakis <joseph.gasparakis@...el.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
cc:	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	Daniel Borkmann <dborkman@...hat.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, John Fastabend <john.r.fastabend@...el.com>
Subject: Re: [net-next v4] vxlan: Notify drivers for listening UDP port
 changes



On Fri, 6 Sep 2013, Stephen Hemminger wrote:

> On Fri, 6 Sep 2013 16:42:26 -0700 (PDT)
> Joseph Gasparakis <joseph.gasparakis@...el.com> wrote:
> 
> > That is correct, I started assuming dev will be a valid pointer, but then 
> > I thought I shouldn't trust the caller, so I ended up with this. In fact I 
> > have some upcoming sparse fixes too, so I will incorporate all this in one 
> > patch. For this particular comment I will be checking dev first and 
> > assigning net and vn after that.
> 
> This is the kernel, audit the callers. We don't add random null
> pointer checks because that is worse. It creates random error paths
> to validate.
> 

Will do. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html