netdev - Re: [Patch net-next v2] net: sync some IP headers with glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <522965E6.8010708@redhat.com>
Date:	Fri, 06 Sep 2013 01:19:34 -0400
From:	"Carlos O'Donell" <carlos@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	amwang@...hat.com, netdev@...r.kernel.org, tmb@...eia.org,
	libc-alpha@...rceware.org, yoshfuji@...ux-ipv6.org
Subject: Re: [Patch net-next v2] net: sync some IP headers with glibc

On 09/04/2013 01:13 PM, David Miller wrote:
> From: Cong Wang <amwang@...hat.com>
> Date: Thu, 15 Aug 2013 17:28:10 +0800
> 
>> Solution:
>> =========
>>
>> - Synchronize linux's `include/uapi/linux/in6.h' 
>>   with glibc's `inet/netinet/in.h'.
>> - Synchronize glibc's `inet/netinet/in.h with linux's
>>   `include/uapi/linux/in6.h'.
>> - Allow including the headers in either other.
>> - First header included defines the structures and macros.
> 
> Applied, thanks for being so patient.  I want to spend the past few
> weeks making sure this is the right way to handle all of this and
> now I am confident that it is.

Pushed into 2.19.

If you compile glibc with old non-UAPI kernel headers then this code
never triggers and glibc continues to redefine the structures and we
have the same problem as always.

If you compile glibc with new UPAI kernel headers, but without the
kernel side patch, you fix the build issues only in one order of
inclusion i.e. linux header then glibc header. Thus previously your
application didn't compile, now it does, but without the kernel
side patch some of the constants glibc define may be missing. At that
point you need to file a bug against the kernel you are using and
request they add the missing constants (or add them yourself).

If you compile glibc with new UAPI kernel headers, and those headers
have the kernel side patch then everything works in any inclusion order
and the defined constants are the superset of those defined in both
implementations.

Note:
- It could have been possible with more added complexity to handle
  the case where the kernel headers have not been patched. I deemed
  that because the code never originally compiled that it was fine
  to continue not compiling in that intermediate state and only support
  the final state as a complete solution. Feel free to disagree.

commit 6c82a2f8d7c8e21e39237225c819f182ae438db3
Author: Carlos O'Donell <carlos@...hat.com>
Date:   Fri Sep 6 01:02:30 2013 -0400

    Coordinate IPv6 definitions for Linux and glibc
    
    This change synchronizes the glibc headers with the Linux kernel
    headers and arranges to coordinate the definition of structures
    already defined the Linux kernel UAPI headers.
    
    It is now safe to include glibc's netinet/in.h or Linux's linux/in6.h
    in any order in a userspace application and you will get the same
    ABI. The ABI is guaranteed by UAPI and glibc.

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html