netdev - Re: [RFC Patch net-next] ipv6: do not allow ipv6 module to be removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1378435971.969.6.camel@cr0>
Date:	Fri, 06 Sep 2013 10:52:51 +0800
From:	Cong Wang <amwang@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	stephen@...workplumber.org
Subject: Re: [RFC Patch net-next] ipv6: do not allow ipv6 module to be
 removed

On Thu, 2013-09-05 at 14:06 -0400, David Miller wrote:
> From: Cong Wang <amwang@...hat.com>
> Date: Wed,  4 Sep 2013 17:12:50 +0800
> 
> > There was some bug report on ipv6 module removal path before.
> > Also, as Stephen pointed out, after vxlan module gets ipv6 support,
> > the ipv6 stub it used is not safe against this module removal either.
> > So, let's just remove inet6_exit() so that ipv6 module will not be
> > able to be unloaded.
> > 
> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > Cc: Stephen Hemminger <stephen@...workplumber.org>
> > Cc: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> I think we should make an effort to make ipv6 unloadable.  If you
> believe little effort is being put into this now, even less will
> be expended if I apply a patch like this one.
> 
> And this patch has a lot of problems, you aren't removing all of
> the functions which will be completely unused.

They are still used in the cleanup path of inet6_init() as well, can't
be removed completely.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html