netdev - Re: [PATCH] bnx2x: avoid atomic allocations during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130907.002952.1951928882694928547.davem@davemloft.net>
Date:	Sat, 07 Sep 2013 00:29:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	mschmidt@...hat.com, netdev@...r.kernel.org, ariele@...adcom.com,
	eilong@...adcom.com
Subject: Re: [PATCH] bnx2x: avoid atomic allocations during initialization

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Sat, 7 Sep 2013 01:45:10 +0000

> Once you allocated the memory during initialization , you will most
> probably fail to allocate its replacement during RX handling (on
> this machine).

Not true, these two events can exist in totally different timeframes
and totally different memory pressure situations.

Probe should never fail because of an atomic memory allocation if at
all possible.

You should use sleeping allocations in every possible situation for
maximum stability, and this absolutely matches the approach taken
by every other major driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html