| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1378788533-5609-1-git-send-email-govindarajulu90@gmail.com> Date: Tue, 10 Sep 2013 10:18:53 +0530 From: Govindarajulu Varadarajan <govindarajulu90@...il.com> To: davem@...emloft.net, netdev@...r.kernel.org Cc: Govindarajulu Varadarajan <govindarajulu90@...il.com> Subject: [PATCH net-next] net: sk_buff: memset(skb,0) after alloc in skb_clone The following patch memset the skb to 0 after alloc. We do this in __alloc_skb_head, __alloc_skb, build_skb. We are missing this in skb_clone. The following call to __skb_clone in skb_clone does not copy all the members of sk_buff. If we donot clear the skb to 0, we will have some uninitialized members in new skb. Signed-off-by: Govindarajulu Varadarajan <govindarajulu90@...il.com> --- net/core/skbuff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index d81cff1..fc78f66 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -891,6 +891,7 @@ struct sk_buff *skb_clone(struct sk_buff *skb, gfp_t gfp_mask) n = kmem_cache_alloc(skbuff_head_cache, gfp_mask); if (!n) return NULL; + memset(n, 0, offsetof(struct sk_buff, tail)); kmemcheck_annotate_bitfield(n, flags1); kmemcheck_annotate_bitfield(n, flags2); -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists