netdev - Re: [PATCH 1/1] net: bnx2x: Staticize local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9yfHxdbs=4saW0oLJgXmK9Be3FpP8rkZ7Y7v-yPbOtuCU+jA@mail.gmail.com>
Date:	Tue, 10 Sep 2013 15:05:27 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Ariel Elior <ariele@...adcom.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Eilon Greenstein <eilong@...adcom.com>
Subject: Re: [PATCH 1/1] net: bnx2x: Staticize local symbols

On 10 September 2013 13:53, Ariel Elior <ariele@...adcom.com> wrote:
>> -----Original Message-----
>> From: netdev-owner@...r.kernel.org [mailto:netdev-
>> owner@...r.kernel.org] On Behalf Of Sachin Kamat
>> Sent: Tuesday, September 10, 2013 9:43 AM
>> To: netdev@...r.kernel.org
>> Cc: davem@...emloft.net; Eilon Greenstein; sachin.kamat@...aro.org
>> Subject: [PATCH 1/1] net: bnx2x: Staticize local symbols

>>
>> -int bnx2x_vf_ndo_prep(struct bnx2x *bp, int vfidx, struct bnx2x_virtf **vf,
>> +static int
> I don't like this form. Better to put the last variable in the next line.

OK. Will change it.

>
> Thanks for suggesting the fix.
> Not sure this is appropriate for net though...

Sorry, did not get this. Please elaborate.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html