lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Sep 2013 22:57:46 +0200 From: Veaceslav Falico <vfalico@...hat.com> To: netdev@...r.kernel.org Cc: jiri@...nulli.us, Veaceslav Falico <vfalico@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Alexander Duyck <alexander.h.duyck@...el.com>, Cong Wang <amwang@...hat.com> Subject: [PATCH v2 net-next 02/27] net: add RCU variant to search for netdev_adjacent link Currently we have only the RTNL flavour, however we can traverse it while holding only RCU, so add the RCU search. Add only one function that will be used further, other functions can be added easily afterwards, if anyone would need them. CC: "David S. Miller" <davem@...emloft.net> CC: Eric Dumazet <edumazet@...gle.com> CC: Jiri Pirko <jiri@...nulli.us> CC: Alexander Duyck <alexander.h.duyck@...el.com> CC: Cong Wang <amwang@...hat.com> Signed-off-by: Veaceslav Falico <vfalico@...hat.com> --- Notes: v1 -> v2: No changes. RFC -> v1: rename neighbour_dev_list/all_dev_list to adj_list/all_adj_list and rework the naming of functions - to make the use the pattern netdev_(all_)(lower|upper)_* . Uninline functions to get better stack traces - inline doesn't give much speed improvement, but this way the stack traces are meaningful. Remove the unused (through the whole patchset) functions - they can easily be added afterwards. net/core/dev.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index f69a8ab..75eabef 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4380,6 +4380,33 @@ struct netdev_adjacent { struct rcu_head rcu; }; +static struct netdev_adjacent *__netdev_find_adj_rcu(struct net_device *dev, + struct net_device *adj_dev, + bool upper, bool neighbour) +{ + struct netdev_adjacent *adj; + struct list_head *adj_list; + + if (neighbour) + adj_list = upper ? &dev->adj_list.upper : + &dev->adj_list.lower; + else + adj_list = upper ? &dev->all_adj_list.upper : + &dev->all_adj_list.lower; + + list_for_each_entry_rcu(adj, adj_list, list) { + if (adj->dev == adj_dev) + return adj; + } + return NULL; +} + +static struct netdev_adjacent *__netdev_lower_find_rcu(struct net_device *dev, + struct net_device *ldev) +{ + return __netdev_find_adj_rcu(dev, ldev, false, true); +} + static struct netdev_adjacent *__netdev_find_adj(struct net_device *dev, struct net_device *adj_dev, bool upper, bool neighbour) -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists