netdev - Re: macvlan: Move skb_clone check closer to call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130911.160403.1705666845363451822.davem@davemloft.net>
Date:	Wed, 11 Sep 2013 16:04:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: macvlan: Move skb_clone check closer to call

From: Simon Horman <horms@...ge.net.au>
Date: Tue, 10 Sep 2013 10:38:10 +0900

> On Sat, Sep 07, 2013 at 12:27:11PM +1000, Herbert Xu wrote:
>> Currently macvlan calls skb_clone in macvlan_broadcast but checks
>> for a NULL return in macvlan_broadcast_one instead.  This is
>> needlessly confusing and may lead to bugs introduced later.
>> 
>> This patch moves the error check to where the skb_clone call is.
>> 
>> The only other caller of macvlan_broadcast_one never passes in a
>> NULL value so it doesn't need the check either.
>> 
>> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> This seems good to me as macvlan_handle_frame(), which is
> the only other caller of macvlan_broadcast_one(), already checks
> that skb is non-NULL before calling macvlan_handle_frame().
> 
> Reviewed-by: Simon Horman <horms@...ge.net.au>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html