netdev - Re: [ethtool 1/3] ethtool: fix ixgbe 82598EB only registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1379003606.9217.0.camel@jekeller-desk1.amr.corp.intel.com>
Date:	Thu, 12 Sep 2013 16:33:26 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [ethtool 1/3] ethtool: fix ixgbe 82598EB only registers

On Thu, 2013-09-12 at 16:45 +0100, Ben Hutchings wrote:
> On Thu, 2013-08-29 at 21:51 +0100, Ben Hutchings wrote:
> > On Tue, 2013-08-27 at 17:08 -0700, Jeff Kirsher wrote:
> > > From: Jacob Keller <jacob.e.keller@...el.com>
> > > 
> > > This patch fixes ixgbe_reg_dump to only display registers specific to the
> > > 82598EB part, as these registers display 0xDEADBEEF otherwise, and clutter up
> > > the register dump.
> > > 
> > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> > > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > > ---
> > >  ixgbe.c | 144 +++++++++++++++++++++++++++++++++-------------------------------
> > >  1 file changed, 75 insertions(+), 69 deletions(-)
> > > 
> > > diff --git a/ixgbe.c b/ixgbe.c
> > > index 9b005f2..89cb6be 100644
> > > --- a/ixgbe.c
> > > +++ b/ixgbe.c
> > [...]
> > > -	fprintf(stdout,
> > > -		"0x02F20: RDPROBE     (Rx Probe Mode Status)           0x%08X\n",
> > > -		regs_buff[1085]);
> > [...]
> > 
> > It looks like this removal really belongs to the next patch, which adds
> > it back with the mac_type < ixgbe_mac_X540 condition.
> 
> Well, I've applied the two patches with this bit fixed up.
> 
> Ben.
> 

Thanks, Ben.

Regards,
Jake