netdev - Re: [PATCH 20/52] net: fealnx: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000e01ceaf4c$90cde130$b269a390$%han@samsung.com>
Date:	Thu, 12 Sep 2013 09:11:01 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Sergei Shtylyov' <sergei.shtylyov@...entembedded.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 20/52] net: fealnx: remove unnecessary pci_set_drvdata()

On Thursday, September 12, 2013 3:20 AM, Jingoo Han wrote:
> On 09/11/2013 11:40 AM, Jingoo Han wrote:
> 
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> 
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > ---
> >   drivers/net/ethernet/fealnx.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> > diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
> > index c706b7a..99194d1 100644
> > --- a/drivers/net/ethernet/fealnx.c
> > +++ b/drivers/net/ethernet/fealnx.c
> > @@ -699,9 +699,9 @@ static void fealnx_remove_one(struct pci_dev *pdev)
> >   		pci_iounmap(pdev, np->mem);
> >   		free_netdev(dev);
> >   		pci_release_regions(pdev);
> > -		pci_set_drvdata(pdev, NULL);
> > -	} else
> > +	} else {
> >   		printk(KERN_ERR "fealnx: remove for unknown device\n");
> > +	}
> 
>     No "drove-by" coding style fixes, please.

Hi Sergei,

Sorry, but I just want to know the reason. :-)
Would you let know the reason not to add coding style fixes?
Thank you.

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html