netdev - Re: [PATCH 7/7] sysfs: @name comes before @ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9ji4sk0.fsf@xmission.com>
Date:	Wed, 11 Sep 2013 20:39:27 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Tejun Heo <tj@...nel.org>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	kay@...y.org, netdev@...r.kernel.org, lizefan@...wei.com
Subject: Re: [PATCH 7/7] sysfs: @name comes before @ns

Tejun Heo <tj@...nel.org> writes:

> Some internal sysfs functions which take explicit namespace argument
> are weird in that they place the optional @ns in front of @name which
> is contrary to the established convention.  This is confusing and
> error-prone especially as @ns and @name may be interchanged without
> causing compilation warning.
>
> Swap the positions of @name and @ns in the following internal
> functions.

Nacked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

@ns is more significant so it should come first.

Where do we have the backwards convention of putting @name first?

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html