netdev - Re: [PATCH] net: tulip: remove deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP6odjg63+g1gLMS9F+O1fQXwFZud10L11P5irJWdQsuDuNXaA@mail.gmail.com>
Date:	Wed, 11 Sep 2013 23:05:56 -0700
From:	Grant Grundler <grantgrundler@...il.com>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	"open list:TULIP NETWORK DRI..." <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: tulip: remove deprecated IRQF_DISABLED

On Wed, Sep 11, 2013 at 9:20 PM, Michael Opdenacker
<michael.opdenacker@...e-electrons.com> wrote:
> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/dec/tulip/de4x5.c
>
> It's a NOOP since 2.6.35 and it will be removed one day.

yup - that was easy to confirm.

> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>

Acked-by: Grant Grundler <grundler@...isc-linux.org>

thanks,
grant

> ---
>  drivers/net/ethernet/dec/tulip/de4x5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
> index 2db6c57..263b92c 100644
> --- a/drivers/net/ethernet/dec/tulip/de4x5.c
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c
> @@ -1321,7 +1321,7 @@ de4x5_open(struct net_device *dev)
>      if (request_irq(dev->irq, de4x5_interrupt, IRQF_SHARED,
>                                                      lp->adapter_name, dev)) {
>         printk("de4x5_open(): Requested IRQ%d is busy - attemping FAST/SHARE...", dev->irq);
> -       if (request_irq(dev->irq, de4x5_interrupt, IRQF_DISABLED | IRQF_SHARED,
> +       if (request_irq(dev->irq, de4x5_interrupt, IRQF_SHARED,
>                                                      lp->adapter_name, dev)) {
>             printk("\n              Cannot get IRQ- reconfigure your hardware.\n");
>             disable_ast(dev);
> --
> 1.8.1.2
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html