lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Sep 2013 10:42:26 -0400 From: Vlad Yasevich <vyasevic@...hat.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: Hong zhi guo <honkiko@...il.com>, netdev@...r.kernel.org, David Miller <davem@...emloft.net>, zhiguohong@...cent.com Subject: Re: [PATCH net-next] fix NULL pointer dereference in br_handle_frame On 09/12/2013 10:33 AM, Eric Dumazet wrote: > On Thu, 2013-09-12 at 22:24 +0800, Hong zhi guo wrote: >> You mean IFF_BRIDGE_PORT should be only for admin/control path, but >> not for data path? > > By definition, br_handle_frame() should be called only when device is a > bridge port. > > After the call to synchronize_net() included in > netdev_rx_handler_unregister(), you have guarantee br_handle_frame() > wont be called. > > Therefore, testing IFF_BRIDGE_PORT in br_handle_frame() is redundant. Don't all tests for IFF_BRIDGE_PORT on the bridge receive path become redundant as well? -vlad > > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists