netdev - [PATCH] ISDN, hfcpci Fix uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1379075296-19976-1-git-send-email-prarit@redhat.com>
Date:	Fri, 13 Sep 2013 08:28:16 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	netdev@...r.kernel.org
Cc:	Prarit Bhargava <prarit@...hat.com>, dzickus@...hat.com,
	Karsten Keil <isdn@...ux-pingi.de>
Subject: [PATCH] ISDN, hfcpci Fix uninitialized warning

Fix uninitialized warning.  Use same fix as
drivers/media/pci/cx18/cx18-alsa-main.c

  CC [M]  drivers/isdn/hardware/mISDN/hfcpci.o
  drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
  drivers/isdn/hardware/mISDN/hfcpci.c:2298:2: error: ignoring return
  value of ‘driver_for_each_device’, declared with attribute
  warn_unused_result [-Werror=unused-result]
    (void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
		      ^

Signed-off-by: Prarit Bhargava <prarit@...hat.com>
Cc: dzickus@...hat.com
Cc: Karsten Keil <isdn@...ux-pingi.de>
---
 drivers/isdn/hardware/mISDN/hfcpci.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
index 7f910c7..2373b44 100644
--- a/drivers/isdn/hardware/mISDN/hfcpci.c
+++ b/drivers/isdn/hardware/mISDN/hfcpci.c
@@ -2295,8 +2295,12 @@ _hfcpci_softirq(struct device *dev, void *arg)
 static void
 hfcpci_softirq(void *arg)
 {
-	(void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
+	int ret;
+
+	ret = driver_for_each_device(&hfc_driver.driver, NULL, arg,
 				      _hfcpci_softirq);
+	if (unlikely(ret))
+		pr_warn("hfcpci_softirq: driver softirq failed\n");
 
 	/* if next event would be in the past ... */
 	if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
-- 
1.7.9.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html