lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Sep 2013 21:58:19 +0800 From: Wei Yang <weiyang@...ux.vnet.ibm.com> To: Wei Yang <weiyang@...ux.vnet.ibm.com> Cc: dm@...lsio.com, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [PATCH] cxgb4: remove workqueue when driver registration fails This time, I cc-ed to myself. And this applies to the latest net tree. It looks not corrupted to me. Not sure other people can see it clearly? On Sun, Sep 15, 2013 at 09:53:00PM +0800, Wei Yang wrote: >When driver registration fails, we need to clean up the resources allocated >before. cxgb4 missed to destroy the workqueue allocated at the very beginning. > >This patch destroies the workqueue when registration fails. > >Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com> >--- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >index 0d0665c..c73cabd 100644 >--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >@@ -6149,8 +6149,10 @@ static int __init cxgb4_init_module(void) > pr_warn("could not create debugfs entry, continuing\n"); > > ret = pci_register_driver(&cxgb4_driver); >- if (ret < 0) >+ if (ret < 0) { > debugfs_remove(cxgb4_debugfs_root); >+ destroy_workqueue(workq); >+ } > > register_inet6addr_notifier(&cxgb4_inet6addr_notifier); > >-- >1.7.1 > >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in >the body of a message to majordomo@...r.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- Richard Yang Help you, Help me -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists