netdev - Re: [PATCH] net, mellanox mlx4 Fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Sep 2013 16:52:06 +0300
From:	Jack Morgenstein <jackm@....mellanox.co.il>
To:	"David Laight" <David.Laight@...LAB.COM>
Cc:	"Or Gerlitz" <or.gerlitz@...il.com>,
	"Prarit Bhargava" <prarit@...hat.com>, <netdev@...r.kernel.org>,
	"Doug Ledford" <dledford@...hat.com>,
	"Amir Vadai" <amirv@...lanox.com>,
	"Or Gerlitz" <ogerlitz@...lanox.com>
Subject: Re: [PATCH] net, mellanox mlx4 Fix compile warnings

On Mon, 16 Sep 2013 09:59:41 +0100
"David Laight" <David.Laight@...LAB.COM> wrote:

> > In any event, this change cannot hurt.  
> 
> It could hide a real 'used but not initialised' error later on...
> 
> 	David

In this case, it doesn't.  If cq_res_start_move_to returns 0, the "cq"
pointer points to the desired cq object.  In all instances where the cq
object is not found, you get an error return, and the cq pointer in the
caller is never de-referenced.

Therefore, the compiler warning is a false positive, and the
"uninitialized_var" is just a workaround to satisfy the compiler.

Same for the SRQ case.

-Jack
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html