netdev - PATCH: periodictimer for mrp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAB5uXS41vHwDHHcCyRbi4PZOGskTkH6nBqHTc7XVBHy+ddvoNg@mail.gmail.com>
Date:	Mon, 16 Sep 2013 13:32:37 -0700
From:	Noel Burton-Krahn <noel@...ton-krahn.com>
To:	netdev@...r.kernel.org
Subject: PATCH: periodictimer for mrp.c

(originally to "David S. Miller" <davem@...emloft.net>, CC'ed to
netdev.  Resent in text/plain)

I ran into a problem when testing MVRP support in net/mrp.c:  MRP
would transmit JoinIn messages before the network interface was fully
up, the packets would be lost, and MRP would never retry.  It looks
like the MRP implementation was missing the periodictimer defined in
[802.1Q-2011] to retry if packets get lost.  The attached patch patch
adds the periodictimer.

Note: As far as I can tell in [802.1Q-2011], the periodic timer never
turns off.  It fires every second, causing MRP to bounce from state QA
to AA and back.  You might think that would stop when the registrar
responds with an JoinIn, but there's no state in the MRP state table
to ignore the periodic timer after getting a reply.  The result is MRP
sends a JoinIn message every second.  This may not be desirable, but
it's what the spec requires.

[802.1Q-2011]
http://standards.ieee.org/findstds/standard/802.1Q-2011.html

Does this look OK to you?

--
Noel

Download attachment "mrp-periodictimer.patch" of type "application/octet-stream" (2955 bytes)