netdev - Re: [PATCH net-next] bridge: change the order of actions in addif/delif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130917092408.19a329b2@nehalam.linuxnetplumber.net>
Date:	Tue, 17 Sep 2013 09:24:08 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Hong Zhiguo <honkiko@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	eric.dumazet@...il.com, vyasevic@...hat.com,
	Hong Zhiguo <zhiguohong@...cent.com>
Subject: Re: [PATCH net-next] bridge: change the order of actions in
 addif/delif

On Tue, 17 Sep 2013 15:44:43 +0800
Hong Zhiguo <honkiko@...il.com> wrote:

> -	/* Device is already being bridged */
> -	if (br_port_exists(dev))
> +	/* Device is already being bridged or registered with other handler */
> +	if (br_port_exists(dev) || dev->rx_handler)
>  		return -EBUSY;

Direct access to dev->rx_handler should be avoided.
The error check should be in netdev_rx_handler_register.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html