netdev - Re: [PATCH 1/2] Re: net, vxlan Fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Sep 2013 21:26:21 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Prarit Bhargava <prarit@...hat.com>
CC:	<netdev@...r.kernel.org>, <jpirko@...hat.com>,
	<davem@...emloft.net>, <stephen@...workplumber.org>
Subject: Re: [PATCH 1/2] Re: net, vxlan Fix compile warning

You don't seem to have completed this change:

On Tue, 2013-09-17 at 15:12 -0400, Prarit Bhargava wrote:
[...]
> @@ -2291,9 +2289,9 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, __be16 port,
>  	INIT_WORK(&vs->del_work, vxlan_del_work);
>  
>  	if (ipv6)
> -		rc = create_v6_sock(net, port, &sock);
> +		sock = create_v6_sock(net, port);
>  	else
> -		rc = create_v4_sock(net, port, &sock);
> +		sock = create_v4_sock(net, port);
>  	if (rc < 0) {

	if (IS_ERR(sock)) {

>  		kfree(vs);
>  		return ERR_PTR(rc);

		return ERR_CAST(sock);

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html