netdev - Re: [PATCH v3 net-next 07/27] net: add for_each iterators through neighbour lower link's private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379381203.23881.22.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 17 Sep 2013 02:26:43 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Veaceslav Falico <vfalico@...hat.com>
CC:	<netdev@...r.kernel.org>, <jiri@...nulli.us>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [PATCH v3 net-next 07/27] net: add for_each iterators through
 neighbour lower link's private

On Tue, 2013-09-17 at 02:46 +0200, Veaceslav Falico wrote:
[...]
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -4537,6 +4537,72 @@ struct net_device *netdev_all_upper_get_next_dev_rcu(struct net_device *dev,
>  }
>  EXPORT_SYMBOL(netdev_all_upper_get_next_dev_rcu);
>  
> +/* netdev_lower_get_next_private - Get the next ->private from the
> + *				   lower neighbour list
[...]

This is not correct kernel-doc syntax.  You must begin the comment like
this:

/**
 * function_name - summary on one physical line, no wrapping allowed

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html