netdev - Re: [PATCH net RFC 2/2] ixgbe: fix sleep bug caused by napi_disable inside local_bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130918230943.GB11989@electric-eye.fr.zoreil.com>
Date:	Thu, 19 Sep 2013 01:09:43 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Jacob Keller <jacob.e.keller@...el.com>
Cc:	netdev@...r.kernel.org,
	Alexander Duyck <alexander.duyck@...el.com>,
	Hyong-Youb Kim <hykim@...i.com>,
	Dmitry Kravkov <dmitry@...adcom.com>,
	Amir Vadai <amirv@...lanox.com>,
	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
Subject: Re: [PATCH net RFC 2/2] ixgbe: fix sleep bug caused by napi_disable
 inside local_bh_disable()d context

Jacob Keller <jacob.e.keller@...el.com> :
> This patch fixes a bug caused by calling napi_disable after local_bh_disable.
> It is possible for napi_disable to sleep, (though not guarunteed) so it could
> cause an atomic sleep bug during the  schedule() call in msleep. This patch
> resolves the issue by moving the local_bh_disable() calls inside the for loop
> in ixgbe_napi_disable_all().

Why couldn't you take mdelay(1) outside of the locally disabled bh section ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html