netdev - Re: [RFC] b44: use phylib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379517545.1787.20.camel@joe-AO722>
Date:	Wed, 18 Sep 2013 08:19:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	zambrano@...adcom.com, netdev@...r.kernel.org,
	Florian Fainelli <florian@...nwrt.org>
Subject: Re: [RFC] b44: use phylib

On Sat, 2013-08-24 at 00:56 +0200, Hauke Mehrtens wrote:
> This splits the driver into the mac and a phy driver. On routers where
> this driver is used we have a switch which implements a phy and can be
> controlled by a phy driver.

One more trivial note:

> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
[]
> +static void b44_adjust_link(struct net_device *dev)
> +{
[]
> +	if (status_changed) {
> +		pr_info("%s: link %s", dev->name, phydev->link ?
> +			"UP" : "DOWN");
> +		if (phydev->link)
> +			pr_cont(" - %d/%s", phydev->speed,
> +			phydev->duplex == DUPLEX_FULL ? "full" : "half");
> +		pr_cont("\n");
> +	}

This bit would be better as:

	if (status_change) {
		if (phydev->link)
			netdev_info(dev, "link UP - %d/%s\n",
				    phydev->speed,
				    phydev->duplex == DUPLEX_FULL
				    ? "full" : "half");
		else
			netdev_info(dev, "link DOWN\n");
	}

so there's no possible interleaving by other
thread messages.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html