lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Sep 2013 16:33:52 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Kevin Curtis <Kevin.Curtis@...site.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "Dermot Smith" <dermot.smith@...site.com> Subject: Re: [PATCH 003/007] WAN Drivers: Update farsync driver and introduce fsflex driver On Wed, 2013-09-18 at 11:12 +0100, Kevin Curtis wrote: > Farsite Communications FarSync driver update > > Patch 3 of 7 > > Introduce a new include file required by the fsflex driver. > > Signed-off-by: Kevin Curtis <kevin.curtis@...site.com> > > --- > > diff -uprN -X linux-3.10.1/Documentation/dontdiff linux-3.10.1/drivers/net/wan/fscmn.h linux-3.10.1_new/drivers/net/wan/fscmn.h > --- linux-3.10.1/drivers/net/wan/fscmn.h 1970-01-01 01:00:00.000000000 +0100 > +++ linux-3.10.1_new/drivers/net/wan/fscmn.h 2013-09-16 16:30:06.779104868 +0100 [...] > +#ifdef UINT32 > +#define u32 UINT32 > +#define u16 UINT16 > +#define u8 UCHAR > +#endif > + > +#ifdef USSTYPES_H > +#define u32 U32 > +#define u16 U16 > +#define u8 U8 > +#endif [...] This sort of cruft doesn't belong in an in-tree driver. unifdef may be useful for removing it when copying in out-of-tree 'portable' code. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists