lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Sep 2013 16:58:15 +0100 From: Ian Campbell <ian.campbell@...rix.com> To: Wei Liu <wei.liu2@...rix.com> CC: Paul Durrant <paul.durrant@...rix.com>, <xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>, David Vrabel <david.vrabel@...rix.com> Subject: Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down On Wed, 2013-09-18 at 11:37 +0100, Wei Liu wrote: > On Tue, Sep 17, 2013 at 05:46:08PM +0100, Paul Durrant wrote: > > Without this patch, if a frontend cycles through states Closing > > and Closed (which Windows frontends need to do) then the netdev > > will be destroyed and requires re-invocation of hotplug scripts > > to restore state before the frontend can move to Connected. Thus > > when udev is not in use the backend gets stuck in InitWait. > > > > With this patch, the netdev is left alone whilst the backend is > > still online and is only de-registered and freed just prior to > > destroying the vif (which is also nicely symmetrical with the > > netdev allocation and registration being done during probe) so > > no re-invocation of hotplug scripts is required. > > > > Signed-off-by: Paul Durrant <paul.durrant@...rix.com> > > Cc: David Vrabel <david.vrabel@...rix.com> > > Cc: Wei Liu <wei.liu2@...rix.com> > > Cc: Ian Campbell <ian.campbell@...rix.com> > > Acked-by: Wei Liu <wei.liu2@...rix.com> yeah, looks good, thanks. Paul, did you test this with non-Windows frontends too? and do things like vif hot(un)plug still work? Ian. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists