netdev - Re: [PATCH] USBNET: fix handling padding packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Sep 2013 12:12:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	ming.lei@...onical.com, gregkh@...uxfoundation.org,
	oneukum@...e.de, netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	oliver@...kum.org
Subject: Re: [PATCH] USBNET: fix handling padding packet

From: Bjørn Mork <bjorn@...k.no>
Date: Wed, 18 Sep 2013 17:52:42 +0200

> Ming Lei <ming.lei@...onical.com> writes:
> 
>> There is no reason to forbid DMA SG for one driver which requires
>> padding, right?
> 
> Yes there is: Added complexity for everybody, based on a combination of
> features which just does not make any sense.
> 
> No modern device should need the padding.  No old device will be able to
> use the SG feature as implemented. You only enable it on USB3, don't
> you? If this feature is restricted to USB3 capable devices, then it most
> certainly can be restricted to ZLP capable devices with absolutely no
> difference in the resulting set of supported devices.

I completely agree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html