netdev - Re: [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130919.140249.933962101950748423.davem@davemloft.net>
Date:	Thu, 19 Sep 2013 14:02:49 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	djduanjiong@...il.com
Cc:	duanj.fnst@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error
 code in icmpv6_err_convert

From: Duan Jiong <djduanjiong@...il.com>
Date: Thu, 19 Sep 2013 13:24:04 +0800

> 于 2013/9/19 0:36, David Miller 写道:
>> From: Duan Jiong <duanj.fnst@...fujitsu.com>
>> Date: Wed, 18 Sep 2013 20:04:48 +0800
>>
>>> From: Duan Jiong <duanj.fnst@...fujitsu.com>
>>>
>>> when dealing with redirect message in udpv6_err() and
>>> rawv6_err() the err shoud be assigned to 0, not EPROTO.
>>>
>>> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
>> No, you should fix this the same way you handled DCCP, but skipping
>> the whole socket error setting path for NDISC_REDIRECT.
> 
> Your meaning is that we should return directly after calling
> ip6_sk_redirect(), is that it?

It depends upon whether udp/raw sockets are expected to receive redirect
notifications this way, are they?  You seem to believe so.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html