netdev - Re: [PATCH net v2 2/2] ip: generate unique IP identificator if local fragmentation is allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130919.141136.38349564506650340.davem@davemloft.net>
Date:	Thu, 19 Sep 2013 14:11:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aatteka@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] ip: generate unique IP identificator if
 local fragmentation is allowed

From: Ansis Atteka <aatteka@...ira.com>
Date: Wed, 18 Sep 2013 15:29:53 -0700

> If local fragmentation is allowed, then ip_select_ident() and
> ip_select_ident_more() need to generate unique IDs to ensure
> correct defragmentation on the peer.
> 
> For example, if IPsec (tunnel mode) has to encrypt large skbs
> that have local_df bit set, then all IP fragments that belonged
> to different ESP datagrams would have used the same identificator.
> If one of these IP fragments would get lost or reordered, then
> peer could possibly stitch together wrong IP fragments that did
> not belong to the same datagram. This would lead to a packet loss
> or data corruption.
> 
> Signed-off-by: Ansis Atteka <aatteka@...ira.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html