netdev - Re: [PATCH net-next v2 1/2] xen-netback: add a vif-is-connected flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130920.144029.56414879806328155.davem@davemloft.net>
Date:	Fri, 20 Sep 2013 14:40:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paul.durrant@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xen.org,
	david.vrabel@...rix.com, wei.liu2@...rix.com,
	ian.campbell@...rix.com
Subject: Re: [PATCH net-next v2 1/2] xen-netback: add a vif-is-connected
 flag

From: Paul Durrant <paul.durrant@...rix.com>
Date: Fri, 20 Sep 2013 14:57:39 +0100

> @@ -169,6 +169,7 @@ struct xenvif {
>  
>  	/* Miscellaneous private stuff. */
>  	struct net_device *dev;
> +	bool connected;
>  };
>  
>  static inline struct xenbus_device *xenvif_to_xenbus_device(struct xenvif *vif)
...
> +	vif->connected = 1;
 ...
> +	vif->connected = 0;

Please use 'true' and 'false' when assigning values to something
of "bool" type.

Also these look like bug fixes, and are thus more appropriately
targetted at 'net' and even potentially -stable as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html