netdev - Re: [PATCH] qlge: call ql_core_dump() only if dump memory was allocated.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130920.150019.390435914325816720.davem@davemloft.net>
Date:	Fri, 20 Sep 2013 15:00:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	malahal@...ibm.com
Cc:	joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH] qlge: call ql_core_dump() only if dump memory was
 allocated.

From: Malahal Naineni <malahal@...ibm.com>
Date: Fri, 20 Sep 2013 13:57:35 -0500

> Joe Perches [joe@...ches.com] wrote:
>> On Fri, 2013-09-20 at 11:59 -0500, Malahal Naineni wrote:
>> > Also changed a log message to indicate that memory was not allocated
>> > instead of memory not available!
>> []
>> > diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_mpi.c b/drivers/net/ethernet/qlogic/qlge/qlge_mpi.c
>> []
>> > @@ -1274,11 +1274,13 @@ void ql_mpi_reset_work(struct work_struct *work)
>> >  		return;
>> >  	}
>> >  
>> > -	if (!ql_core_dump(qdev, qdev->mpi_coredump)) {
>> > -		netif_err(qdev, drv, qdev->ndev, "Core is dumped!\n");
>> > -		qdev->core_is_dumped = 1;
>> > -		queue_delayed_work(qdev->workqueue,
>> > -			&qdev->mpi_core_to_log, 5 * HZ);
>> > +	if (qdev->mpi_coredump) {
>> > +		if (!ql_core_dump(qdev, qdev->mpi_coredump)) {
>> > +			netif_err(qdev, drv, qdev->ndev, "Core is dumped!\n");
>> > +			qdev->core_is_dumped = 1;
>> > +			queue_delayed_work(qdev->workqueue,
>> > +				&qdev->mpi_core_to_log, 5 * HZ);
>> > +		}
>> 
>> This can be done without adding another indentation level
>> 
>> 	if (qdev->mpi_coredump &&
>> 	    !ql_core_dump(qdev, qdev->mpi_coredump)) {
>> 
>> 
> 
> Makes sense! Sending another patch as suggested:

Please don't send new versions of a patch as a reply to a thread,
instead always make a new, fresh, list posting.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html