netdev - Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Sep 2013 02:21:37 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Russell King <rmk+kernel@....linux.org.uk>
CC:	<alsa-devel@...a-project.org>, <b43-dev@...ts.infradead.org>,
	<devel@...verdev.osuosl.org>, <devicetree@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>,
	<e1000-devel@...ts.sourceforge.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-crypto@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-fbdev@...r.kernel.org>, <linux-ide@...r.kernel.org>,
	<linux-media@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<linux-nvme@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linux-tegra@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	"Solarflare linux maintainers" <linux-net-drivers@...arflare.com>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	Rob Landley <rob@...dley.net>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and
 coherent DMA masks

On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote:
> Provide a helper to set both the DMA and coherent DMA masks to the
> same value - this avoids duplicated code in a number of drivers,
> sometimes with buggy error handling, and also allows us identify
> which drivers do things differently.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> ---
>  Documentation/DMA-API-HOWTO.txt |   37 ++++++++++++++++++++++---------------
>  Documentation/DMA-API.txt       |    8 ++++++++
>  include/linux/dma-mapping.h     |   14 ++++++++++++++
>  3 files changed, 44 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
> index 14129f1..5e98303 100644
> --- a/Documentation/DMA-API-HOWTO.txt
> +++ b/Documentation/DMA-API-HOWTO.txt
[...]
> -dma_set_coherent_mask() will always be able to set the same or a
> -smaller mask as dma_set_mask(). However for the rare case that a
> +The coherent coherent mask will always be able to set the same or a
> +smaller mask as the streaming mask. However for the rare case that a
[...]

The new wording doesn't make sense; a mask doesn't set itself.  I would
suggest:

"The coherent mask can always be set to the same or a smaller mask than
the streaming mask."

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html