netdev - Re: [PATCH 1/1] mrp: add periodictimer to allow retries when packets get lost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523CF71D.3090002@ll.mit.edu>
Date:	Fri, 20 Sep 2013 21:32:13 -0400
From:	"Ward, David - 0663 - MITLL" <david.ward@...mit.edu>
To:	David Miller <davem@...emloft.net>
CC:	"noel@...ton-krahn.com" <noel@...ton-krahn.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>
Subject: Re: [PATCH 1/1] mrp: add periodictimer to allow retries when
 packets get lost

Noel, thanks for your patch. This timer was apparently not in the GARP 
standard but added in the MRP standard and I missed it. Looks good to me.

Acked-by: David Ward <david.ward@...mit.edu>


On 09/20/2013 02:59 PM, David Miller wrote:
> Re: [PATCH 1/1] mrp: add periodictimer to allow retries when packets 
> get lost
>
> From: Noel Burton-Krahn <noel@...ton-krahn.com>
> Date: Wed, 18 Sep 2013 12:24:40 -0700
>
> > MRP doesn't implement the periodictimer in 802.1Q, so it never retries
> > if packets get lost.  I ran into this problem when MRP sent a MVRP
> > JoinIn before the interface was fully up.  The JoinIn was lost, MRP
> > didn't retry, and MVRP registration failed.
> >
> > Tested against Juniper QFabric switches
> >
> > Signed-off-by: Noel Burton-Krahn <noel@...ton-krahn.com>
>
> David W., please review this patch.
>
> Thanks.
>



Download attachment "smime.p7s" of type "application/pkcs7-signature" (4571 bytes)