netdev - Re: [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D310C490-3B7D-4937-95DC-AFC1682B60BE@juniper.net>
Date:	Sun, 22 Sep 2013 23:09:35 +0000
From:	Anirban Chakraborty <abchak@...iper.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Wei Liu <wei.liu2@...rix.com>,
	"<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
	"<xen-devel@...ts.xen.org>" <xen-devel@...ts.xen.org>,
	Ian Campbell <ian.campbell@...rix.com>
Subject: Re: [PATCH net-next] xen-netfront: convert to GRO API and advertise
 this feature


On Sep 22, 2013, at 7:55 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:

> On Sat, 2013-09-21 at 17:05 +0100, Wei Liu wrote:
>> Anirban was seeing netfront received MTU size packets, which downgraded
>> throughput. The following patch makes netfront use GRO API which
>> improves throughput for that case.
> 
>> -	netdev->hw_features	= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
>> +	netdev->hw_features	= NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO |
>> +				  NETIF_F_GRO;
> 
> 
> This part is not needed.

Shouldn't the flag be set? In dev_gro_receive() we do check if this flag is set or not:

        if (!(skb->dev->features & NETIF_F_GRO) || netpoll_rx_on(skb))
               goto normal;

-Anirban



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html