netdev - Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52403478.6010305@atmel.com>
Date:	Mon, 23 Sep 2013 14:30:48 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Russell King <rmk+kernel@....linux.org.uk>,
	<alsa-devel@...a-project.org>, <b43-dev@...ts.infradead.org>,
	<devel@...verdev.osuosl.org>, <devicetree@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>,
	<e1000-devel@...ts.sourceforge.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-crypto@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-fbdev@...r.kernel.org>, <linux-ide@...r.kernel.org>,
	<linux-media@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<linux-nvme@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linux-tegra@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	<uclinux-dist-devel@...ckfin.uclinux.org>
CC:	Kukjin Kim <kgene.kim@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

On 20/09/2013 00:01, Russell King :
> The correct way for a driver to specify the coherent DMA mask is
> not to directly access the field in the struct device, but to use
> dma_set_coherent_mask().  Only arch and bus code should access this
> member directly.
>
> Convert all direct write accesses to using the correct API.
>
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> ---
>   drivers/usb/chipidea/ci_hdrc_imx.c |    5 +++--
>   drivers/usb/dwc3/dwc3-exynos.c     |    5 +++--
>   drivers/usb/gadget/lpc32xx_udc.c   |    4 +++-
>   drivers/usb/host/ehci-atmel.c      |    5 +++--

For Atmel driver:

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

[..]

> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 3b645ff..5831a88 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -92,8 +92,9 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
>   	 */
>   	if (!pdev->dev.dma_mask)
>   		pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
> -	if (!pdev->dev.coherent_dma_mask)
> -		pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> +	retval = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> +	if (retval)
> +		goto fail_create_hcd;
>
>   	hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
>   	if (!hcd) {

[..]

Thanks,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html