netdev - RE: [PATCH ethtool] sfc: Add support for EF10 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7354@saturn3.aculab.com>
Date:	Mon, 23 Sep 2013 17:14:42 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Ben Hutchings" <bhutchings@...arflare.com>,
	<netdev@...r.kernel.org>
Cc:	<linux-net-drivers@...arflare.com>
Subject: RE: [PATCH ethtool] sfc: Add support for EF10 registers

>  struct efx_nic_reg_field {
>  	const char *name;
>  	u32 lbn:7, width:8;
> -	u32 min_revision:2, max_revision:2;
> +	u32 min_revision:3, max_revision:3;
>  };
...
>  struct efx_nic_reg_table {
>  	const char *name;
>  	const struct efx_nic_reg_field *fields;
>  	u32 field_count:7;
> -	u32 min_revision:2, max_revision:2;
> +	u32 min_revision:3, max_revision:3;
>  	u32 step:6, rows:21;
>  };

These bitfields look rather pointless.
AFACT the size of the structures wouldn't change if the fields
were just u8 or u32. The code would be a lot smaller.

	David