netdev - Re: question tehuti.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130924153432.GI9773@gospo.rdu.redhat.com>
Date:	Tue, 24 Sep 2013 11:34:32 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexander Indenbaum <baum@...utinetworks.net>
Subject: Re: question tehuti.c

On Mon, Sep 23, 2013 at 05:54:00PM +0200, Julia Lawall wrote:
> The function bdx_setmulti in the file drivers/net/ethernet/tehuti/tehuti.c
> contains:
> 
>         u32 rxf_val =
>             GMAC_RX_FILTER_AM | GMAC_RX_FILTER_AB | GMAC_RX_FILTER_OSEN;
> 
> and then later:
> 
>        } else {
>                 DBG("only own mac %d\n", netdev_mc_count(ndev));
>                 rxf_val |= GMAC_RX_FILTER_AB;
>         }
> 
> The last assignment doesn't look very useful, because GMAC_RX_FILTER_ABis
> already included in rxf_val.  Was something else intended?

You are correct that the setting of GMAC_RX_FILTER_AB is a bit redundant
since it was set earlier in the function.

I have not worked on this driver in several years and if there is no
response from Alexander or someone else at Tehuti Networks then you may
not get an answer to your question. :-/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html