lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Sep 2013 12:09:06 -0700 From: Jesse Brandeburg <jesse.brandeburg@...el.com> To: David Miller <davem@...emloft.net> Cc: <joe@...ches.com>, <jeffrey.t.kirsher@...el.com>, <netdev@...r.kernel.org>, <gospo@...hat.com>, <sassmann@...hat.com> Subject: Re: [net 5/6] i40e: better return values On Tue, 24 Sep 2013 10:12:31 -0400 David Miller <davem@...emloft.net> wrote: > > Ick. post_increment problem. > > > > return ++num_tc; > > > > There's nothing wrong with the original code > > unless this is a bugfix which should be documented > > better than "better return values". > > Agreed, this style of coding is asking for a bug. > > If you want to return "num_tc PLUS ONE" just say that: > > return num_tc + 1; Oops! Obviously the original post-inc was not the intent. That was my bad. good catch Joe! will fix and resubmit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists