netdev - Re: [PATCH 08/10] toshiba: Remove extern from function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380058004.9509.1.camel@smoke>
Date:	Tue, 24 Sep 2013 14:26:44 -0700
From:	Geoff Levand <geoff@...radead.org>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Ishizaki Kou <kou.ishizaki@...hiba.co.jp>,
	Jens Osterkamp <jens@...ibm.com>, cbe-oss-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] toshiba: Remove extern from function prototypes

On Tue, 2013-09-24 at 14:10 -0700, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources.  Standardize on not using extern for
> function prototypes.
> 
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler.  Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/net/ethernet/toshiba/ps3_gelic_net.h      | 29 +++++++++++------------
>  drivers/net/ethernet/toshiba/ps3_gelic_wireless.h |  6 ++---
>  drivers/net/ethernet/toshiba/spider_net.h         |  4 ++--
>  3 files changed, 19 insertions(+), 20 deletions(-)

Looks good.  Thanks.

Acked-by: Geoff Levand <geoff@...radead.org>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html