netdev - Re: [PATCH 02/10] intel: Remove extern from function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130924.213435.2244969028650079031.davem@davemloft.net>
Date:	Tue, 24 Sep 2013 21:34:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	jeffrey.t.kirsher@...el.com, joe@...ches.com,
	netdev@...r.kernel.org, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, gregory.v.rose@...el.com,
	peter.p.waskiewicz.jr@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, tushar.n.dave@...el.com,
	e1000-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] intel: Remove extern from function prototypes

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 24 Sep 2013 23:16:52 +0100

> On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote:
>> On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote:
>> > There are a mix of function prototypes with and without extern
>> > in the kernel sources.  Standardize on not using extern for
>> > function prototypes.
>> > 
>> > Function prototypes don't need to be written with extern.
>> > extern is assumed by the compiler.  Its use is as unnecessary as
>> > using auto to declare automatic/local variables in a block.
>> 
>> So you are able to confirm that all compilers make this assumption
>> correctly?  The initial reason for using extern was because not all
>> compilers made the assumption or made it correctly.
> 
> You are probably thinking of global variables, where declarations
> without either 'extern' or an initialiser might or might not be treated
> as 'common'.  On function declarations, 'extern' really is redundant.

Furthermore, these networking headers include existing generic kernel
headers which already have removed the 'extern' from function
declarations in certain cases.

So I don't think there isn't an issue, and if there is it has existed
already for some time. :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html