netdev - Re: [PATCH net] ip_tunnel: Do not use stale inner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380129051.3165.158.camel@edumazet-glaptop>
Date:	Wed, 25 Sep 2013 10:10:51 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ip_tunnel: Do not use stale inner_iph pointer.

On Wed, 2013-09-25 at 09:57 -0700, Pravin B Shelar wrote:
> While sending packet skb_cow_head() can change skb header which
> invalidates inner_iph pointer to skb header. Following patch
> avoid using it. Found by code inspection.
> 
> This bug was introduced by commit 0e6fbc5b6c6218 (ip_tunnels: extend
> iptunnel_xmit()).
> 
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ---
>  net/ipv4/ip_tunnel.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html