netdev - Re: Kernel Panic Sending Frames Using dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFu7c2VdLARbFOBQ3MDGiSOUPgpVz6-A-66t1xXeGGnu0C8bzg@mail.gmail.com>
Date:	Wed, 25 Sep 2013 19:47:15 -0700
From:	Merlin Davis <me.the.wizard@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org
Subject: Re: Kernel Panic Sending Frames Using dev_queue_xmit()

On Wed, Sep 25, 2013 at 3:03 PM, Francois Romieu <romieu@...zoreil.com> wrote:
> Macro expansion bug.

Yes!  Excellent.  If I change the code to:

   err = dev_queue_xmit(skb);
   err = net_xmit_eval(err);

then the panic seems to disappear (I've run for at least 30 minutes
now without a crash anyway).  Would the best fix for this in the
kernel code be to:

A.) document the net_xmit_eval() macro with a warning,
B.) add local scope the the macro with ({ ... }) to remove the double
evaluation, or
C.) do nothing in the kernel code and stop being such a dumbass when calling it?

Thank you,
Merlin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html