[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130926214406.GB19788@verge.net.au>
Date: Fri, 27 Sep 2013 06:44:07 +0900
From: Simon Horman <horms@...ge.net.au>
To: Magnus Damm <magnus.damm@...il.com>
Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
SH-Linux <linux-sh@...r.kernel.org>,
Russell King - ARM Linux <linux@....linux.org.uk>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup
On Wed, Sep 25, 2013 at 11:50:45PM -0700, Magnus Damm wrote:
> On Fri, Sep 13, 2013 at 5:29 PM, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com> wrote:
> > Currently on the Lager board NFS timeouts/delays are seen when booting. That
> > turned out to happen because the SoC's ETH_LINK signal turns on and off after
> > each packet. It is connected to Micrel KSZ8041 PHY's LED0 signal. Ether LEDs
> > on the Lager board are named LINK and ACTIVE which corresponds to non-default
> > 01 setting of the PHY control register 1 bits 14-15. The 'sh_eth' driver resets
> > the PHY when opening the network device, so we have to set the mentioned bits
> > back to 01 from the default 00 value which causes bouncing of ETH_LINK. That
> > can be achieved using the PHY platform fixup mechanism if we also modify the
> > driver to use it..
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
> Hi Sergei,
>
> Thanks for your efforts on this. Nice to see that Ethernet for Lager
> board support is improving.
>
> Can you please share with us with link speeds you tested? I suspect
> that this patch is only needed for some case, like for instance 100
> MBit Full Duplex. Fixing the PHY settings makes sense even though only
> a single mode needs it, but knowing which link speeds that are known
> to work would help a lot.
Magnus,
I currently have this queued up as a fix for v3.12.
Let me know if you would like me to drop it for now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists