netdev - Re: [PATCH] sh_eth: NAPI requires netif_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1309261751200.11968@axis700.grange>
Date:	Thu, 26 Sep 2013 18:12:29 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	David Miller <davem@...emloft.net>
cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
	nobuhiro.iwamatsu.yj@...esas.com, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: NAPI requires netif_receive_skb()

Hi

On Wed, 4 Sep 2013, David Miller wrote:

> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Date: Tue, 3 Sep 2013 03:03:10 +0400
> 
> > Driver supporting NAPI should use NAPI-specific function for receiving packets,
> > so netif_rx() should be changed to netif_receive_skb().
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

This patch breaks NFS boot on Armadillo800eva for me. Network 
communication slows down to a crawl with

net eth0: Receive FIFO Overflow
nfs: server 192.168.x.y not responding, still trying

With this patch reverted (e.g. in today's Linus tree snapshot) boot is 
restored.

Thanks
Guennadi

> Applied.

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html