netdev - Re: [PATCH net-next v4 1/3] flow_dissector: factor out the ports extraction in skb_flow_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380213202.3165.195.camel@edumazet-glaptop>
Date:	Thu, 26 Sep 2013 09:33:22 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, andy@...yhouse.net,
	fubar@...ibm.com, vfalico@...hat.com
Subject: Re: [PATCH net-next v4 1/3] flow_dissector: factor out the ports
 extraction in skb_flow_get_ports

On Thu, 2013-09-26 at 18:13 +0200, Nikolay Aleksandrov wrote:

>  	flow->ip_proto = ip_proto;
> -	poff = proto_ports_offset(ip_proto);
> -	if (poff >= 0) {
> -		__be32 *ports, _ports;
> -
> -		nhoff += poff;
> -		ports = skb_header_pointer(skb, nhoff, sizeof(_ports), &_ports);
> -		if (ports)
> -			flow->ports = *ports;
> -	}
> -
> +	flow->ports = skb_flow_get_ports(skb, nhoff, ip_proto);
>  	flow->thoff = (u16) nhoff;
>  
>  	return true;



The best way is to ask David to apply my fix in net tree, then your
patch will be on top of it.

Mixing a fix and a factoring seems not right.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html