netdev - Re: [PATCH net-next] net: neighbour: use source address of last enqueued packet for solicitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130926.134655.889702001911014781.davem@redhat.com>
Date:	Thu, 26 Sep 2013 13:46:55 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, ja@....bg
Subject: Re: [PATCH net-next] net: neighbour: use source address of last
 enqueued packet for solicitation

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Sat, 21 Sep 2013 06:32:34 +0200

> Currently we always use the first member of the arp_queue to determine
> the sender ip address of the arp packet (or in case of IPv6 - source
> address of the ndisc packet). This skb is fixed as long as the queue is
> not drained by a complete purge because of a timeout or by a successful
> response.
> 
> If the first packet enqueued on the arp_queue is from a local application
> with a manually set source address and the to be discovered system
> does some kind of uRPF checks on the source address in the arp packet
> the resolving process hangs until a timeout and restarts. This hurts
> communication with the participating network node.
> 
> This could be mitigated a bit if we use the latest enqueued skb's
> source address for the resolving process, which is not as static as
> the arp_queue's head. This change of the source address could result in
> better recovery of a failed solicitation.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Julian Anastasov <ja@....bg>
> Reviewed-by: Julian Anastasov <ja@....bg>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied, but honestly I think the tail packet has just as much chance
to come from an application with a manually set source address as
the head one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html